Enforce keypath exclusivity as an error. #16491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flag supports promoting KeyPath access violations to an error in Swift 4+, while building the standard library in Swift 3 mode. This is only necessary as long as the standard library continues to build in Swift 3 mode. Once the standard library build migrates, it can all be ripped out. <rdar://problem/40115738> [Exclusivity] Enforce Keypath access as an error, not a warning in 4.2.
Modify IRGen to emit builtin access markers with an error flag in Swift 3 mode. KeyPath enforcement is required by user code in Swift 4+ mode, but is implemented within the standard library. A [builtin] flag marks the special case for access generated by Builtins so that they are always enforced as an error regardless of the language mode. This is necessary for Swift 4.2 because the standard library continues to build in Swift 3 mode. Once the standard library build migrates, this is all irrelevant. This does not actually affect existing Swift 3 code, since the KeyPath feature wasn't introduced until Swift 4. <rdar://problem/40115738> [Exclusivity] Enforce Keypath access as an error, not a warning in 4.2.
Contributor
Author
|
In case some tooling needs the radar number in the PR instead of the commit log: |
Contributor
Author
|
@swift-ci test. |
Contributor
Author
|
@swift-ci test source compatibility. |
Contributor
|
Build failed |
I noticed this during testing, but it has nothing to do with the other changes in this PR. This static violation has always been present as a warning and would continue to be a warning after my changes.
Contributor
Author
|
I don't think the two stdlib validation test timeouts are related to these changes. Both tests pass quickly in my local build. |
Contributor
Author
|
@swift-ci test. |
Contributor
|
Build failed |
Contributor
|
Build failed |
gottesmm
approved these changes
May 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that it's necessary to special case exclusivity Builtins and add flags to SIL instructions because of a couple circumstances: