IRGen: Fix enum lowering with -enable-resilience-bypass #16488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The layout of an enum type will only use spare bits if the payload types have a fixed size in all resilience domains where they are visible. In practice, this means that: - If the enum is internal or resilient, we can use spare bits if the payload types are fixed size from inside the current module. - If the enum is public and not resilient, we can use spare bits if the payload types are fixed size from all resilience domains. The bug was that the 'fixed size in all resilience domains' check was returning true for resilient types when the -enable-resilience-bypass flag was on. This is wrong, because this meant that building a module with and without -enable-resilience-bypass could produce different lowerings for enum types. Fixes <rdar://problem/40034143>.
Contributor
Author
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rdar://problem/40034143.