[CSGen] Mark visitDynamicMemberRefExpr as unreachable to match ExprRewriter and update SanitizeExpr to handle them #15627
Conversation
|
@swift-ci please test |
nathawes
force-pushed
the
reachable-unreachables
branch
from
c79d7e7 to
59db0ca
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
There was a problem hiding this comment.
Ah actually this has to use mock-sdk as an option, can you please fix?
There was a problem hiding this comment.
Yeah, sure. Like below?
// RUN: %target-swift-frontend(mock-sdk: %clang-importer-sdk) -typecheck %s -verify
// REQUIRES: objc_interop
import Foundation
...
There was a problem hiding this comment.
Yes! Sorry U didn’t notice it right away...
There was a problem hiding this comment.
No worries - thanks for reviewing it! I'll update shortly.
…writer and update SanitizeExpr to handle them We were hitting an unreachable in visitDynamicMemberExpr in ExprRewriter when re-typechecking during a salvage. Check for these earlier (in CSGen) and update SanitizeExpr to handle them. Resolves rdar://problem/39055736
nathawes
force-pushed
the
reachable-unreachables
branch
from
59db0ca to
0145439
Compare
|
@swift-ci please test and merge |
|
@swift-ci please test |
|
Build failed |
|
Build failed |
3 participants
We were hitting an unreachable in
visitDynamicMemberRefExprinExprRewriterwhen re-typechecking within salvage. Check for these earlier (in CSGen) and update SanitizeExpr to handle them.