Skip to content

[string] Add less bad SPI for Foundation #15442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2018
Merged

[string] Add less bad SPI for Foundation #15442

merged 1 commit into from
Mar 23, 2018

Conversation

@milseman
Copy link
Member

@milseman milseman commented Mar 23, 2018

Add a couple scoped SPI for Foundation to use, as the old _StringCore based ones are going away soon.

@milseman milseman requested a review from airspeedswift March 23, 2018 03:50
@milseman
Copy link
Member Author

milseman commented Mar 23, 2018

@swift-ci please smoke test

1 similar comment
@shahmishal
Copy link
Member

shahmishal commented Mar 23, 2018

@swift-ci please smoke test

@milseman milseman merged commit 3957bae into swiftlang:master Mar 23, 2018
@milseman milseman deleted the i_spi_something_string branch March 23, 2018 15:37
@airspeedswift
Copy link
Member

airspeedswift commented Mar 23, 2018

LGTM

@milseman milseman mentioned this pull request Mar 23, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@airspeedswift airspeedswift Awaiting requested review from airspeedswift

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@milseman @shahmishal @airspeedswift