Fix multi-arch cross-compiling #15085
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On platforms without fat binaries (anything but Darwin), we now build and install stdlibs for each arch in it's own folder. Namely lib/swift/<platform>/<arch> instead of lib/swift/<platform>.
This is a hacky fix for an issue where build-script-impl gets the ninja command invocations from `ninja -n -v` incorrectly. Ninja gets a few commands, including `clang++ ... -o somelib`, which assumes incorrectly that we're in `swift-linux-x86_64` and thus errors out on the build process. This change just lets ninja do the work at the cost of potentially scrambling the lit progress bar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebased version of #13108
Pushing here to get the logs.