build: effectively revert 986beb75225a09969f71123f134967eecef0dcd5 #13209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change broke the Windows builds for all the variants. `-z defs` cannot be used on all targets, particularly in environments where the stdlib is being compiled for a foreign host. This needs to be handled more carefully as I mentioned on the PR itself. In the mean time, revert it to get Windows building again.
Member
Author
Member
Author
|
@swift-ci please test and merge |
Contributor
Contributor
|
Hi @compnerd – Thank you for selectively reverting just the part doesn't work for you instead of reverting the whole patch. That leaves the change I made to SwiftRemoteMirror in place that I need. That being said, I think it is unfortunate to strip |
Contributor
|
@davezarzycki #13140 should take care of that, although I’m not sure if there’s a more elegant way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change broke the Windows builds for all the variants.
-z defscannot beused on all targets, particularly in environments where the stdlib is being
compiled for a foreign host. This needs to be handled more carefully as I
mentioned on the PR itself. In the mean time, revert it to get Windows building
again.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.