Fix the value of Float80.pi
#12881
Merged
Fix the value of Float80.pi
#12881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test |
airspeedswift
approved these changes
Nov 12, 2017
Member
airspeedswift
left a comment
airspeedswift
left a comment
There was a problem hiding this comment.
Fine with merging as is, but I think you can remove more code without harm.
| return 0x1.921fb54442d18p1 as Double | ||
| %elif bits == 80: | ||
| return Float80(0x1.921fb54442d1846ap1) | ||
| return 0x1.921fb54442d1846ap1 as Float80 |
Member
There was a problem hiding this comment.
The type of var pi itself ought to be enough type context, you can probably drop the as.
Contributor
Author
|
@swift-ci Please test. |
Contributor
Author
|
@airspeedswift You're absolutely right. Updated. |
Contributor
Author
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this is implemented as
Float80(literal), which gets interpreted asFloat80(Double(literal)), unfortunately. Switch to the correct spelling:literal as Float80.Resolves rdar://problem/35459284