Disable an unnecessary assert in AccessSummaryAnalysis. #10654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I’m totally disabling this assert in 4.0. Tracking down a compiler crash for each obscure case of missing access marker is not a good use of time since we’re not actually fixing these cases when we find them anyway. Instead, post 4.0, we will catch all of these missing cases by implementing strong SIL verification. Much more SILGen work is really required to fully implement exclusivity diagnostics. SIL verification will be necessary to drive that. Fixes <rdar://problem/33024357> AccessSummaryAnalysis assert "Unrecognized argument use" building source compatibility siesta project.
Contributor
Author
|
@swift-ci smoke test and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’m totally disabling this assert in 4.0. Tracking down a compiler crash for
each obscure case of missing access marker is not a good use of time since we’re
not actually fixing these cases when we find them anyway. Instead, post 4.0, we
will catch all of these missing cases by implementing strong SIL
verification. Much more SILGen work is really required to fully implement
exclusivity diagnostics. SIL verification will be necessary to drive that.
Fixes rdar://problem/33024357 AccessSummaryAnalysis assert "Unrecognized
argument use" building source compatibility siesta project.