[Shepherd] build: create and use a wrapper for add_llvm_tool_symlink #10337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a new function `add_swift_tool_symlink`. Use this instead of the `add_llvm_tool_symlink` and `install_in_swift_component`. This mimics the behaviour in clang as well as the general pattern of renaming the functions from the LLVM build infrastructure.
Contributor
Author
|
@swift-ci please clean smoke test |
llvm-beanz
approved these changes
Jun 16, 2017
Contributor
llvm-beanz
left a comment
llvm-beanz
left a comment
There was a problem hiding this comment.
Looks reasonable to me.
Contributor
Author
|
⛵️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased and updated #6053