Store a collection of patterns to match against in Configuration.TestFilter instead of chaining multiple pattern-matcher filters #494
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a crash which can occur if there are many filter or skip arguments passed to the testing library's entry point.
In this situation, before this fix, one
Configuration.TestFilterwas created for each filter or skip argument and they were chained together to form a tree usingcombining(with:using:). Then, they were applied to a test graph recursively. If this tree was deep due to having many filter or skip arguments chained together, the recursion could exceed the stack and cause a crash.The fix is to change
Configuration.TestFilter.Kind.patternso that it can store multiple patterns to match against instead of just one. This makes it more aligned with the other cases in its enum, which also store collections, and prevents the crash since it typically results in much shallower filter trees.Result:
Crash is resolved, validated by a new unit test.
Checklist: