Use String(reflecting:) instead of _typeName(_:qualified:) to get the fully-qualified names of types.
#325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the fully-qualified names of types. We were directly using the Swift standard library function `_typeName(_:qualified:)` to get the fully-qualified names of types, but `String(reflecting:)` does this for us and is supported API. This PR switches us over to the API.
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
grynspan
changed the title
String(reflecting:) instead of _typeName(_:qualified:) to get…String(reflecting:) instead of _typeName(_:qualified:) to get the fully-qualified names of types.
|
@swift-ci please test |
dennisweissmann
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were directly using the Swift standard library function
_typeName(_:qualified:)to get the fully-qualified names of types, butString(reflecting:)does this for us and is supported API. This PR switches us over to the API.Checklist: