Make Attachment always conform to CustomStringConvertible.
#1367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR ensures that `Attachment` conforms to `CustomStringConvertible` even if the value it wraps is non-copyable. We accomplish this by creating a new helper function that is able to box an arbitrary `~Copyable` value in `Any` if its type is actually `Copyable`. (This requires a newer runtime on Apple platforms, so we fall back to a generic (`~Copyable`) implementation on older macOS/iOS/etc.) We then call this helper function in `Attachment.description` and if it returns a value, we can stringify it.
grynspan
added
the
command-line experience
grynspan
added
the
attachments/activities
jerryjrchen
approved these changes
Oct 16, 2025
Contributor
jerryjrchen
left a comment
jerryjrchen
left a comment
There was a problem hiding this comment.
LGTM. Are there already existing test cases that test the Attachment description behaviours? If not, would it be feasible to include as part of this PR?
Contributor
Author
|
We already have test coverage, yes. |
Contributor
Author
|
Holding for @stmontgomery to look at. |
stmontgomery
approved these changes
Oct 20, 2025
grynspan
deleted the
jgrynspan/attachment-always-conform-to-customstringconvertible
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that
Attachmentconforms toCustomStringConvertibleeven if the value it wraps is non-copyable. We accomplish this by creating a new helper function that is able to box an arbitrary~Copyablevalue inAnyif its type is actuallyCopyable. (This requires a newer runtime on Apple platforms, so we fall back to a generic (~Copyable) implementation on older macOS/iOS/etc.) We then call this helper function inAttachment.descriptionand if it returns a value, we can stringify it.Checklist: