swift test should warn when --filter excludes all tests (_à la_ XCTest.)
#128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CTest.) When using XCTest and `swift test --filter`, if all tests are filtered out a diagnostic of the form: > warning: No matching test cases were run Is emitted by SwiftPM. We should have a similar warning we emit from swift-testing in this scenario.
grynspan
changed the title
swift test should warn when --filter excludes all tests (_à la_ X…swift test should warn when --filter excludes all tests (_à la_ XCTest.)
|
Draft for now because we may end up needing to implement the relevant logic in a single location in SwiftPM so that the message reflects the overall output, not per-library output. TBD. |
|
No longer required due to #536 and swiftlang/swift-package-manager#7777. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using XCTest and
swift test --filter, if all tests are filtered out a diagnostic of the form:Is emitted by SwiftPM. We should have a similar warning we emit from swift-testing in this scenario.
Checklist: