Remove group info for SwiftSyntax #322
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving `Diagnostic` etc. to the `SwiftSyntaxParser` module required `swift-format` to import `SwiftSyntaxParser` in a bunch of places where it shouldn’t be needed. Move the types back to the `SwiftSyntax` module for now until we completely refactor the parser to just return `Diagnostics` and not require a `DiagnsoticEngine` (tracked by SR-15280).
AFAICT the group info was only used for swift modules built by `build-script.py`. But since we don’t ship the swift modules as part of the toolchain anymore and the intended way to build SwiftSyntax for clients is through the SwiftPM package, I think the maintainance cost is higher than the value it provides (which I think has always been marginal).
|
@swift-ci Please test |
|
This has value in contexts where the module files are provided separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #321.
AFAICT the group info was only used for swift modules built by
build-script.py. But since we don’t ship the swift modules as part of the toolchain anymore and the intended way to build SwiftSyntax for clients is through the SwiftPM package, I think the maintainance cost is higher than the value it provides (which I think has always been marginal).