-
Notifications
You must be signed in to change notification settings - Fork 446
SwiftSyntax support for module selectors #3091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
beccadax
wants to merge
16
commits into
swiftlang:main
Choose a base branch
from
beccadax:mod-squad
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+5,586
−738
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
69d50cd
[NFC] Thread experimental features through lexer
beccadax 1360c37
Add experimental colonColon token
beccadax 06f2097
[NFC] Refactor parsing of suppressed types
beccadax ee93aa6
[NFC] Tighten checking for PBD introducers
beccadax d848067
[NFC] Correct @_implements diagnostic typo
beccadax 762ce11
[NFC] Generate code for experimental nodes better
beccadax e1eab9a
[NFC] Add module selector syntax nodes/children
beccadax 0321c86
[NFC] Refactor parseQualifiedTypeIdentifier()
beccadax e27a511
Parse module selectors in most valid locations
beccadax 0e8e6ee
Diagnose and recover from bad module selectors
beccadax 6a66de7
Support module selectors in scoped imports
beccadax b4ac41a
Allow module selectors before missing types/exprs
beccadax e1c3cf2
Improve module selector (and other) diagnostics
beccadax c570aac
Fix a parameter label recovery edge case
beccadax 8adfdb1
Don’t drop module selector in bad generic arg list
beccadax 46eb9ee
Fix issue with SPI protocol requirement
beccadax File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't feel using
MissingExprSyntax
as dangling module selector is the way to go.MissingExprSyntax
is a "placeholder" for expression with unknown kind. But IMO, we can reasonably assume the user is to add an identifier after a module selector to formDeclReferenceExprSyntax
.I feel it's more natural to model it as
DeclReferenceExprSyntax
with missingbaseName
.Same for
MissingTypeSyntax