Skip to content

Revert "[Syntax] Use BumpPtrAllocator for Syntax node internals" #2933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2025
Merged

Revert "[Syntax] Use BumpPtrAllocator for Syntax node internals" #2933

merged 1 commit into from
Jan 9, 2025

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Jan 9, 2025

Reverts #2925

This broke macOS package jobs e.g. https://ci.swift.org/job/oss-swift-package-macos/3776/console

error: link command failed with exit code 1 (use -v to see invocation)
ld: warning: ignoring file 'lib/swift/host/lib_SwiftSyntaxCShims.a[2](PlatformMutex.c.o)': found architecture 'x86_64', required architecture 'arm64'
ld: Undefined symbols:
  _swiftsyntax_platform_mutex_create, referenced from:

@rintaro
Copy link
Member Author

rintaro commented Jan 9, 2025

@swift-ci Please test

@ahoppen
Copy link
Member

ahoppen commented Jan 9, 2025

@swift-ci Please test Windows

@rintaro rintaro merged commit a57f3be into main Jan 9, 2025
3 checks passed
@rintaro rintaro deleted the revert-2925-syntax-data-arena branch January 9, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahoppen ahoppen Awaiting requested review from ahoppen ahoppen is a code owner

@bnbarham bnbarham Awaiting requested review from bnbarham bnbarham is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rintaro @ahoppen