Fix CodeGenerationFormat.formatChildrenSeparatedByNewline() to not add an extra newline to the end of lists that already have one
#2823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…add an extra newline to the end of a list that already has one
roopekv
changed the title
CodeGenerationFormat.formatChildrenSeparatedByNewline() to not add an extra newline to the end of lists that already have one
…Newline` Co-authored-by: Alex Hoppen <[email protected]>
Contributor
Author
|
Do I squash commits, or is this ok? |
Contributor
Author
|
The view mode change didn't affect generated code, but it made the line longer so that it should wrap. I'll run format and commit once more. EDIT: Done |
Member
|
@swift-ci Please test |
Member
|
@swift-ci Please test |
Member
|
@swift-ci Please test Windows |
1 similar comment
Member
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where
CodeGenerationFormat.formatChildrenSeparatedByNewline()adds an extra newline to the end of lists that already have one.