Fix: Incorrect insertion location in fix-it for )
#2492
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2431
Changes Summary:
1. Added
shouldBeInsertedBeforePreviousTokenTrivia
Extracted this from existing code from
DiagnosticExtensions.swift
Inserted this just after existing property
shouldBeInsertedAfterNextTokenTrivia
This extraction is needed as we want to reuse this while deciding correct insertion location of fix-it
2. Correct insertion location for fix-it in
MissingNodesError.swift
This should correct
)
,:
,,
syntax positions which should be inserted before previous token trivia. i.e. should not have whitespace before them. (check unit tests corrections for examples)3. Correction of Unit Tests
Corrected the existing unit tests where
missing ')' token
error was expected.Notice that we only change location markers and not other things in the unit tests.
None of the
fixedSource
in the examples in unit tests are changed4. Added couple of Unit Tests
testRighParenLocation()
testTypeExpr31()