Make SyntaxArena.hasParent an atomic boolean
#2440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci Please test |
…iftPM This fixes a concurrency issue in SyntaxArena. Building `_AtomicBool` using CMake is more tricky because the CMake infrastructure in swift-syntax doesn’t know how to build C modules. Since the compiler is only single-threaded race conditions are impossible, so we fake `AtomicBool` for now in CMake builds. rdar://121324116
ahoppen
force-pushed
the
ahoppen/has-parent-atomic
branch
from
ad2412d to
232c4b8
Compare
Member
Author
|
@swift-ci Please test |
Member
Author
|
@swift-ci Please test macOS |
Member
Author
|
@swift-ci Please test Windows |
rintaro
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a concurrency issue in
SyntaxArena.Building
_AtomicBoolusing CMake is more tricky because the CMake infrastructure in swift-syntax doesn’t know how to build C modules. Since the compiler is only single-threaded race conditions are impossible, so we fakeAtomicBoolfor now in CMake builds.rdar://121324116