Fix compilation errors in SwiftRefactorExtension. #2061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed RefactoringProvider to EditRefactoringProvider and SyntaxRefactoringProvider. Current code seems to assume SyntaxRefactoringProvider.
Contributor
|
@swift-ci please test |
ahoppen
approved these changes
Aug 15, 2023
Member
ahoppen
left a comment
ahoppen
left a comment
There was a problem hiding this comment.
Thank you @kishikawakatsumi. Looks like we aren’t checking that the editor extension builds in CI. 😬
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
RefactoringProvidertoEditRefactoringProviderandSyntaxRefactoringProvider.RefactoringProviderno longer exists. Current code seems to assume inheritSyntaxRefactoringProvider.