Skip to content

Conversation

@ahoppen
Copy link
Member

@ahoppen ahoppen commented Jul 26, 2023

No description provided.

@ahoppen
Copy link
Member Author

ahoppen commented Jul 26, 2023

@swift-ci Please test macOS

@ahoppen ahoppen changed the title WIP: More renames of syntax nodes More renames of syntax nodes Jul 26, 2023
@ahoppen ahoppen marked this pull request as ready for review July 26, 2023 19:52
@ahoppen ahoppen requested a review from DougGregor as a code owner July 26, 2023 19:52
@ahoppen ahoppen requested a review from bnbarham July 26, 2023 19:52
@ahoppen
Copy link
Member Author

ahoppen commented Jul 26, 2023

swiftlang/swift-stress-tester#244

@swift-ci Please test macOS

),
Child(
name: "RawStringDelimiter",
name: "Pounds",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly I think I prefer RawStringDelimiter. That's mostly because pounds just reads weirdly to me though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline, with pounds, I think is easier to understand what this represents.

),
Child(
name: "Expression",
name: "Subject",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reference calls this the "control expression" FWIW

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The compiler calls it “subject”. I think I prefer “subject”.

@ahoppen
Copy link
Member Author

ahoppen commented Jul 26, 2023

@ahoppen
Copy link
Member Author

ahoppen commented Jul 27, 2023

@ahoppen
Copy link
Member Author

ahoppen commented Jul 27, 2023

1 similar comment
@kimdv
Copy link
Contributor

kimdv commented Jul 27, 2023

@ahoppen ahoppen merged commit be8dc65 into swiftlang:main Jul 27, 2023
@ahoppen ahoppen deleted the ahoppen/renames branch July 27, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants