Simplify TokenSpec in CodeGeneration
#1943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci Please test |
kimdv
approved these changes
Jul 25, 2023
bnbarham
approved these changes
Jul 25, 2023
ahoppen
force-pushed
the
ahoppen/simplify-tokenspec
branch
from
bd93fbd to
95328cc
Compare
Member
Author
|
@swift-ci Please test |
Member
Author
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three cleanups to
TokenSpec:TokenSpecclass hierarchy (which dates back to the Python days) into a single structTokenSpec.associatedValueClass: At some point I introduce the abstraction with the idea to also have aTokenKindwith associated values for pound keywords and operators but that never happenedTokenSpec.swiftKindtovarOrCaseNameand change it from a string toTokenSyntax.