Move additional swift compiler flags from build-script to Package.swift #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allevato
reviewed
Oct 28, 2019
aciidgh
reviewed
Oct 29, 2019
ahoppen
force-pushed
the
swift-args-in-package
branch
2 times, most recently
from
a006c16 to
5d58ab6
Compare
Member
Author
|
Thanks for all your feedback. I have updated the PR to only specify the unsafe flags when we are in a controlled CI environment, i.e. if @swift-ci Please test |
Contributor
|
Build failed |
Member
|
@swift-ci Please test |
Contributor
|
Build failed |
Member
Author
|
@swift-ci Please test |
Contributor
|
Build failed |
Member
|
@swift-ci Please test |
Member
Author
|
I have modified this PR to only contain unsafe flags when we are in a controlled CI environment, i.e. if the environment variable Could you please take another look at the changes? |
ahoppen
changed the title
akyrtzi
reviewed
Oct 29, 2019
ahoppen
force-pushed
the
swift-args-in-package
branch
from
5d58ab6 to
032a456
Compare
akyrtzi
approved these changes
Oct 29, 2019
allevato
approved these changes
Oct 29, 2019
This allows for a more consistent build, independent of whether build-script was used or not. This will allow us to use a unified build directory for all packages depending on Swift later on.
ahoppen
force-pushed
the
swift-args-in-package
branch
from
032a456 to
c1209f6
Compare
Member
Author
|
@swift-ci Please test |
adevress
pushed a commit
to adevress/swift-syntax
that referenced
this pull request
Jan 14, 2024
Add `ignore-unparsable-files` to silence diagnostics for invalid syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving all additional Swift compiler flags from
build-script.pytoPackage.swiftallows for a more consistent build, independent of whether build-script was used or not.This will allow us to use a unified build directory for all packages depending on Swift later on.