Fix a couple cases where the formatting in CodeGeneration was off #1561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the new BasicFormat, these cases will be formatted weirdly, so I want to update them now.
|
@swift-ci Please test |
bnbarham
reviewed
Apr 20, 2023
Comment on lines
-92
to
+93
| ) | ||
|
|
||
| ) |
There was a problem hiding this comment.
Weird, but I assume the new will fix this?
There was a problem hiding this comment.
I’m not entirely sure yet what’s going wrong here. Still need to investigate but I didn’t think it would make sense to investigate in the current BasicFormat.
bnbarham
approved these changes
Apr 20, 2023
kimdv
approved these changes
Apr 20, 2023
This was referenced Apr 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new BasicFormat from #1558, these cases will be formatted weirdly, so I want to update them now.