Don't allow single-line string literals to span multiple lines #1419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When parsing the end of an interpolation segment, even if there is a closing `)` present, the lexer may still think it's inside a nested position in an interpolated segment. As such, make sure to always tell it to move back to string literal mode for better diagnostics.
We were missing a check for multi-line literals here.
There were a few cases where we could parse tokens that had leading trivia, causing us to incorrectly accept some single-line string literals that spanned multiple lines. Fix up these cases to ensure the tokens we parse don't have leading trivia.
Contributor
Author
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a few cases where we could parse tokens that had leading trivia, causing us to incorrectly accept some single-line string literals that spanned multiple lines. Fix up these cases to ensure the tokens we parse don't have leading trivia.