Add diagnostic message for identifier editor placeholder #1380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
reviewed
Mar 7, 2023
Member
ahoppen
left a comment
ahoppen
left a comment
There was a problem hiding this comment.
This won’t work as-is because there are other places that also consume an identifier and would consume the editor placeholder as a normal identifier without emitting an error.
Instead, I think the error should be emitted by the Lever. You can take a look at Cursor.swift. There are a few cases that add a LexerDiagnostic. We should do the same for editor placeholders.
kimdv
force-pushed
the
kimdv/add-diagnostic-message-for-identifier-editor-placeholder
branch
from
e29a2f6 to
c892162
Compare
Contributor
Author
|
@swift-ci please test |
kimdv
force-pushed
the
kimdv/add-diagnostic-message-for-identifier-editor-placeholder
branch
from
c892162 to
21a3c0e
Compare
ahoppen
approved these changes
Mar 9, 2023
Member
ahoppen
left a comment
ahoppen
left a comment
There was a problem hiding this comment.
That’s exactly what I was thinking of 🤩
Member
|
@swift-ci Please test |
kimdv
force-pushed
the
kimdv/add-diagnostic-message-for-identifier-editor-placeholder
branch
2 times, most recently
from
6da1002 to
ef5965a
Compare
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test macOS |
kimdv
force-pushed
the
kimdv/add-diagnostic-message-for-identifier-editor-placeholder
branch
from
ef5965a to
6e50efb
Compare
Contributor
Author
|
@swift-ci please test |
3 similar comments
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test |
ahoppen
approved these changes
Mar 24, 2023
kimdv
force-pushed
the
kimdv/add-diagnostic-message-for-identifier-editor-placeholder
branch
from
6e50efb to
c4e8030
Compare
Contributor
Author
|
@swift-ci please test |
ahoppen
reviewed
Mar 24, 2023
kimdv
force-pushed
the
kimdv/add-diagnostic-message-for-identifier-editor-placeholder
branch
3 times, most recently
from
f17ec89 to
5833797
Compare
kimdv
force-pushed
the
kimdv/add-diagnostic-message-for-identifier-editor-placeholder
branch
from
5833797 to
0054642
Compare
Contributor
Author
|
@swift-ci please test |
ahoppen
approved these changes
Mar 24, 2023
Contributor
Author
|
@swift-ci please test |
kimdv
deleted the
kimdv/add-diagnostic-message-for-identifier-editor-placeholder
branch
kimdv
added a commit
to kimdv/swift-syntax
that referenced
this pull request
Mar 25, 2023
…sage-for-identifier-editor-placeholder
kimdv
added a commit
to kimdv/swift-syntax
that referenced
this pull request
Mar 25, 2023
…sage-for-identifier-editor-placeholder
ahoppen
pushed a commit
to ahoppen/swift-syntax
that referenced
this pull request
Mar 31, 2023
…sage-for-identifier-editor-placeholder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of fixing an TODOs in here: #1373
I just wanna ask if I'm on the right path.