Move raw syntax nodes from gyb to code gen #1326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimdv
force-pushed
the
kimdv/move-raw-syntax-nodes-from-gyb-to-code-gen
branch
2 times, most recently
from
b26a19e to
4ecc624
Compare
ahoppen
approved these changes
Feb 9, 2023
Member
ahoppen
left a comment
ahoppen
left a comment
There was a problem hiding this comment.
Nice. This is looking great. I’ve got one wish (which you can ignore) and one comment inline.
Really looking forward to the day *.gyb is gone 😍
| } | ||
| } | ||
| + (node.collectionElementChoices?.isEmpty == false | ||
| ? [("Element", node.collectionElementChoices!.map { choice -> (String, String) in (SYNTAX_NODE_MAP[choice]!.swiftSyntaxKind, SYNTAX_NODE_MAP[choice]!.name) })] |
Member
There was a problem hiding this comment.
It would be nice if we had something like ChildKind for Node as well so we don’t need to force-unwrap here. But I think that’s something we can more easily do once we’ve gotten rid of all the gyb. In general, I feel like there’s a lot we can clean up in the SyntaxSupport module once we’re no longer tied to the Python design.
CodeGeneration/Sources/generate-swiftsyntax/templates/swiftsyntax/RawSyntaxNodesFile.swift
Outdated
Show resolved
Hide resolved
kimdv
force-pushed
the
kimdv/move-raw-syntax-nodes-from-gyb-to-code-gen
branch
from
4ecc624 to
a1898d6
Compare
Contributor
Author
|
@swift-ci please test |
kimdv
force-pushed
the
kimdv/move-raw-syntax-nodes-from-gyb-to-code-gen
branch
from
a1898d6 to
ac46401
Compare
Contributor
Author
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.