Rename LexerError -> TokenDiagnostic
#1320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci Please test |
ahoppen
force-pushed
the
ahoppen/rename-lexererror
branch
from
b39a7de to
3f06676
Compare
Member
Author
|
@swift-ci Please test |
Member
Author
|
@swift-ci Please test |
`LexerError` has been the wrong name for this for two reasons: - It could also contain warnings generated by the lexer - It also contained errors about insufficient indentation that weren’t generated by the lexer `TokenDiagnostic` is the best name I have found to describe what this is doing.
ahoppen
force-pushed
the
ahoppen/rename-lexererror
branch
from
3f06676 to
9b7605c
Compare
Member
Author
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LexerErrorhas been the wrong name for this for two reasons:TokenDiagnosticis the best name I have found to describe what this is doing.