Don’t use arrays in consume functions
#1314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci Please test |
rintaro
reviewed
Feb 6, 2023
| protocol P { } | ||
| """, | ||
| substructure: Syntax(TokenSyntax.identifier("rethrows")), | ||
| substructure: Syntax(TokenSyntax.keyword(.rethrows)), |
Member
There was a problem hiding this comment.
Just curious, what changed the behavior?
Member
Author
There was a problem hiding this comment.
Oh that was because I forgot to check remapping in consume(if:). Fixed now.
Creating arrays for `consume(ifAny:)` and friends incurs memory allocations and reference counting costs. Stamp out copies of `consume(if:)` for up to three different kinds and start using `RawTokenKindSubset` if more kinds need to be checked. This improves performance of parsing MovieSwiftUI by 5%. rdar://103774645
ahoppen
force-pushed
the
ahoppen/no-arrays
branch
from
9b9acf0 to
2036cab
Compare
Member
Author
|
@swift-ci Please test |
1 similar comment
Member
Author
|
@swift-ci Please test |
rintaro
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating arrays for
consume(ifAny:)and friends incurs memory allocations and reference counting costs. Stamp out copies ofconsume(if:)for up to three different kinds and start usingRawTokenKindSubsetif more kinds need to be checked.This improves performance of parsing MovieSwiftUI by 5%.
rdar://103774645