Disallow where clause in generic argument list #1127
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IIRC, we still use this syntax in SIL |
|
Since we don’t use SwiftSyntax to represent SIL, this shouldn’t be an issue though, right? |
The where clause in the generic argument list hasn’t been supported for quite a few Swift releaeses. Don’t support it in the new parser.
ahoppen
force-pushed
the
ahoppen/no-deprecated-generic-where
branch
from
823067c to
357b554
Compare
|
@swift-ci Please test |
|
Oh dear, we are still parsing all the tests in the Swift test suite with language mode 4 and language mode 4 still supports where clauses in generic argument lists. 🙄 |
|
I’m closing this because it’s unlikely we’ll be able to merge this anytime soon. Opened #1417 so we don’t forget about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The where clause in the generic argument list hasn’t been supported for quite a few Swift releaeses. Don’t support it in the new parser.