Add support for FreeBSD #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakepetroules
force-pushed
the
eng/PR-freebsd
branch
from
f1f1afa to
4e853c3
Compare
owenv
approved these changes
Jun 30, 2025
Also includes speculative support for OpenBSD, which I haven't tested, but which is likely correct as it tends to require the same code paths as FreeBSD.
jakepetroules
force-pushed
the
eng/PR-freebsd
branch
from
4e853c3 to
ad63fd6
Compare
parkera
reviewed
Jul 1, 2025
| @@ -285,8 +285,14 @@ internal func monitorProcessTermination( | |||
|
|
|||
| // Small helper to provide thread-safe access to the child process to continuations map as well as a condition variable to suspend the calling thread when there are no subprocesses to wait for. Note that Mutex cannot be used here because we need the semantics of pthread_cond_wait, which requires passing the pthread_mutex_t instance as a parameter, something the Mutex API does not provide access to. | |||
| private final class ChildProcessContinuations: Sendable { | |||
| #if os(FreeBSD) || os(OpenBSD) | |||
| typealias MutexType = pthread_mutex_t? | |||
There was a problem hiding this comment.
This is unfortunate. Why would we support an optional lock?
There was a problem hiding this comment.
For Linux/Glibc, pthread_mutex_t is a union, but on OpenBSD/FreeBSD, it is a pointer.
Unfortunately in the view of swift this could potentially be a null pointer and hence becomes imported as an optional pointer type.
There was a problem hiding this comment.
Long-term, once we have a separate module map and platform overlay, we should API-note it with the appropriate nullability information.
swiftlang/swift#81407
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes speculative support for OpenBSD, which I haven't tested, but which is likely correct as it tends to require the same code paths as FreeBSD.