Remove @testable imports in the SwiftEvolve and make all requirements public #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
CI testing passed: https://ci.swift.org/job/swift-PR-osx-preset/78/ |
ahoppen
force-pushed
the
swiftevolve-remove-testable
branch
from
641f4f5 to
ee88cb4
Compare
beccadax
approved these changes
Nov 5, 2019
Contributor
beccadax
left a comment
beccadax
left a comment
There was a problem hiding this comment.
Looks fine at a glance.
ahoppen
force-pushed
the
swiftevolve-remove-testable
branch
from
ee88cb4 to
38bee51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@testableimports require a full rebuild of SwiftEvolve.We can avoid that cost if we make all the tested declarations public and remove the
@testable.