Allow depending on local dependencies for CI #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
force-pushed
the
local-dependencies
branch
from
972db26 to
f9ec6bf
Compare
CI doesn't need to fetch the master dependencies from GitHub when it has already checked out the sources beforehand.
ahoppen
force-pushed
the
local-dependencies
branch
from
f9ec6bf to
b2a871b
Compare
Member
Author
|
CI testing passed: https://ci.swift.org/job/swift-PR-osx-preset/77 |
nathawes
approved these changes
Nov 1, 2019
build-script-helper.py
Outdated
| check_call(args, verbose=verbose) | ||
|
|
||
| # Tell SwiftSyntax that we are building in a CI environment so that it does | ||
| # not need to rebuilt if it has already been built bevore. |
There was a problem hiding this comment.
typo: "not need to be rebuilt if it has already been built before".
Specify the environment variable SWIFT_SYNTAX_CI_ENVIRONMENT to build SwiftSyntax with the same compiler options as it is being built before in CI. This allows us to later use a unified build for the two projects, and thus avoiding to build SwiftSyntax twice.
SwiftPM does not get the rpath for XCTests in multiroot packages right (rdar://56793593). As a temporary workaround we just add the correct rpath as an unsafe linker flag.
ahoppen
force-pushed
the
local-dependencies
branch
from
1a91b29 to
5be177f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don’t need to fetch the dependencies from GitHub if they are already checked out.
To do this, we tell SwiftSyntax that we are building in a build script environment by passing the environment variable
SWIFT_BUILD_SCRIPT_ENVIRONMENT. This causes us to link against the dylib instead of the static library.Linking against dylibs of other packages does not currently work, because SwiftPM is not setting the correct rpath, hence we need to manually specify these rpaths as
@loader_path/../../../