-
Notifications
You must be signed in to change notification settings - Fork 157
+add Distributed Actors #730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@swift-ci please test |
Is this known failure? |
|
Hm, I thought I handled that by 🤔 But I can also make it such that we don't need that testable import, I'll look into it. |
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
@ktoso 👋 Adding to the projects.json sets the default when and end-user doesn't override the build config via the cmd-line. In pr testing we use And in our nightly CI we have jobs for both debug and release builds, so we'll need the project to build with both configurations. If you need to compile tests as part of your build_portion, add *You will likely need to merge main into your branch for this to work as this is relatively new functionality. |
|
Thanks @justice-adams-apple , actually this is resolved I just need to bump the commit we point at I noticed. Worse though, there is a regression in Swift that makes the library crash, I'm looking into it rdar://104583893 and will re-request tests/inclusion here. |
c2c3c5f to
e6e0481
Compare
|
Okey this should work fine I hope! We also fixed the regression now in Swift itself that this maybe could have helped prevent. |
|
@swift-ci please test |
|
Sweet, thanks! |
Pull Request Description
Now that swift 5.7 is stable we really should be testing the distributed actors cluster because it is the large codebase pushing both swift concurrency and the distributed feature.
https://github.com/apple/swift-distributed-actors
This requires 5.7 so we need to add that Swuft support... not entirely sure how to do that, will reach out to someone.
Acceptance Criteria
To be accepted into the Swift source compatibility test suite, a project must:
./project_precommit_checkscript run