Skip to content

Add tags to swift-testing tests that have withKnownIssue calls. #9312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 3, 2025
Merged

Add tags to swift-testing tests that have withKnownIssue calls. #9312

merged 2 commits into from
Nov 3, 2025

Conversation

@kcieplak
Copy link
Contributor

@kcieplak kcieplak commented Oct 30, 2025

  • Add tags for tracking to tests that have withKnownIssue invocations, for bucketing and tracking purposes.
  • Fix spelling mistake for "Component"

@kcieplak
Add tags to swift-testing tests that have withKnownIssue calls.
8714962 
* Add tags for tracking to tests that have withKnownIssue invocations,
for bucketing and tracking purposes.
* Fix spelling mistake for "Component"
@kcieplak
Copy link
Contributor Author

kcieplak commented Oct 30, 2025

@swift-ci test

@kcieplak
Copy link
Contributor Author

kcieplak commented Oct 30, 2025

@swift-ci test windows

bkhouri
bkhouri approved these changes Oct 30, 2025
View reviewed changes
@kcieplak
Updates from review
7ccfd83 
* Do not duplicate the tags already on the suite.
* Add trailing comma on test tags
@kcieplak
Copy link
Contributor Author

kcieplak commented Oct 30, 2025

@swift-ci test

@kcieplak
Copy link
Contributor Author

kcieplak commented Oct 30, 2025

@swift-ci test windows

@kcieplak
Copy link
Contributor Author

kcieplak commented Oct 31, 2025

@swift-ci test windows platform

@bkhouri
Copy link
Contributor

bkhouri commented Oct 31, 2025

@swift-ci test windows

@kcieplak kcieplak merged commit fcf3c12 into swiftlang:main Nov 3, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@owenv owenv owenv approved these changes

@bkhouri bkhouri bkhouri approved these changes

@jakepetroules jakepetroules Awaiting requested review from jakepetroules jakepetroules is a code owner

@dschaefer2 dschaefer2 Awaiting requested review from dschaefer2 dschaefer2 is a code owner

@shawnhyam shawnhyam Awaiting requested review from shawnhyam

@bripeticca bripeticca Awaiting requested review from bripeticca bripeticca is a code owner

@plemarquand plemarquand Awaiting requested review from plemarquand plemarquand is a code owner

@cmcgee1024 cmcgee1024 Awaiting requested review from cmcgee1024 cmcgee1024 is a code owner

@daveyc123 daveyc123 Awaiting requested review from daveyc123 daveyc123 is a code owner

@rconnell9 rconnell9 Awaiting requested review from rconnell9 rconnell9 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kcieplak @bkhouri @owenv