Skip to content

Cleanup some unnecessary build setting #9234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2025
Merged

Cleanup some unnecessary build setting #9234

merged 1 commit into from
Oct 21, 2025

Conversation

@daveinglis
Copy link
Contributor

  • fix adding -lc++ to OTHER_LDFLAGS to match native build system.
  • remove OTHER_LDRFLAGS setting

@daveinglis
Copy link
Contributor Author

@swift-ci test

@daveinglis daveinglis mentioned this pull request Oct 9, 2025
Closed
@daveinglis daveinglis requested a review from owenv October 9, 2025 18:03
jakepetroules
jakepetroules requested changes Oct 9, 2025
View reviewed changes
@daveinglis
Cleanup some unnecessary build setting
a1f5e0d 
- fix adding -lc++ to OTHER_LDFLAGS to match native build system.
@daveinglis
Copy link
Contributor Author

@swift-ci test

1 similar comment
@daveinglis
Copy link
Contributor Author

@swift-ci test

@daveinglis
Copy link
Contributor Author

@swift-ci test windows

@daveinglis daveinglis enabled auto-merge (squash) October 20, 2025 20:19
@daveinglis
Copy link
Contributor Author

@jakepetroules I need you to review and remove you requested change if you are ok with this.

jakepetroules
jakepetroules approved these changes Oct 21, 2025
View reviewed changes
Copy link
Contributor

@jakepetroules jakepetroules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but I think there's still a couple improvements you could make (see inline comments)

@daveinglis daveinglis merged commit fae1549 into swiftlang:main Oct 21, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakepetroules jakepetroules jakepetroules approved these changes

@owenv owenv owenv approved these changes

@dschaefer2 dschaefer2 Awaiting requested review from dschaefer2 dschaefer2 is a code owner

@shawnhyam shawnhyam Awaiting requested review from shawnhyam shawnhyam is a code owner

@bripeticca bripeticca Awaiting requested review from bripeticca bripeticca is a code owner

@plemarquand plemarquand Awaiting requested review from plemarquand plemarquand is a code owner

@bkhouri bkhouri Awaiting requested review from bkhouri bkhouri is a code owner

@cmcgee1024 cmcgee1024 Awaiting requested review from cmcgee1024 cmcgee1024 is a code owner

@daveyc123 daveyc123 Awaiting requested review from daveyc123 daveyc123 is a code owner

@rconnell9 rconnell9 Awaiting requested review from rconnell9 rconnell9 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@daveinglis @jakepetroules @owenv