fix modulemap generation on window using swift-build #9179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
daveinglis
commented
Sep 23, 2025
daveinglis
commented
- Windows paths need to be escaped
daveinglis
requested review from
bkhouri,
bripeticca,
cmcgee1024,
daveyc123,
dschaefer2,
jakepetroules,
owenv,
plemarquand,
rconnell9 and
shawnhyam
as code owners
Contributor
Author
|
@swift-ci test |
daveinglis
force-pushed
the
window_modules_fix
branch
from
87b54d3 to
b9af1d3
Compare
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test windows |
owenv
approved these changes
Sep 23, 2025
Contributor
|
Are there any tests we can enable, or remove "withKnownIssue" from |
bkhouri
approved these changes
Sep 23, 2025
jakepetroules
approved these changes
Sep 23, 2025
Contributor
jakepetroules
left a comment
jakepetroules
left a comment
There was a problem hiding this comment.
Note: I'd like to see this modulemap generation be moved down into the Swift Build layer in the fullness of time, PIF generation does not at all seem like the right place for it. This is a historical artifact.
Contributor
|
@swift-ci please test self hosted windows |
1 similar comment
Contributor
Author
|
@swift-ci please test self hosted windows |
- Windows paths need to be escaped
daveinglis
force-pushed
the
window_modules_fix
branch
from
b9af1d3 to
cc800d3
Compare
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test windows |
1 similar comment
Contributor
Author
|
@swift-ci test windows |
bripeticca
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.