mark a failing test on linux+swiftbuild as withKnownIssue (moduleDirectDeps2) #9150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daveinglis
requested review from
bkhouri,
bripeticca,
cmcgee1024,
daveyc123,
dschaefer2,
jakepetroules,
owenv,
plemarquand and
shawnhyam
as code owners
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test linux |
daveinglis
changed the title
owenv
approved these changes
Sep 17, 2025
plemarquand
reviewed
Sep 17, 2025
…ps2) This was previously marked as a known Issue before but got changed in another PR resulting in a PR merge race causing breakage.
daveinglis
force-pushed
the
linux_test_fix
branch
from
2bbd5ca to
9186cd8
Compare
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test windows |
bkhouri
reviewed
Sep 18, 2025
| } | ||
| } when: { | ||
| ProcessInfo.hostOperatingSystem == .windows && buildSystem == .swiftbuild | ||
| buildSystem == .swiftbuild |
Contributor
There was a problem hiding this comment.
do we understand what started to cause this failure as the change that added support for module aliasing in SwiftBuild has passed on all platforms, except Windows due to known issues.
Contributor
Author
There was a problem hiding this comment.
yes, we need to fix SwiftBuild linker task to specify linked libraries correctly. This will be my next update soon
Closed
1 task
Contributor
|
Merging to unblock PR testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs to be investigated
rdar://160781783