Tests: Update helpers to support both test libraries #9082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkhouri
requested review from
jakepetroules,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
cmcgee1024 and
daveyc123
as code owners
|
@swift-ci test |
owenv
approved these changes
Sep 2, 2025
bkhouri
force-pushed
the
t/main/test_helpers_support_both_st_and_xctest
branch
from
2cb180b to
4c35205
Compare
|
@swift-ci test |
|
@swift-ci test windows |
|
@swift-ci please test self hosted windows |
The `_InternalTestSupport` and `_InternalBuildTestSupport` modules have XCTest assert helper functions, that, when called from a Swift Testing test, is essentially a no-op. During migration to Swift Testing, this could lead to false positives if the helpers function are not converted to use Swift Testing APIs. During the transition, update all helper functions to detect whether the caller is executing in the XCTest or Swift Testing context, and call the appropriate API given the library.
bkhouri
force-pushed
the
t/main/test_helpers_support_both_st_and_xctest
branch
from
4c35205 to
aba200a
Compare
|
@swift-ci test |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_InternalTestSupportand_InternalBuildTestSupportmodules have XCTest assert helper functions, that, when called from a Swift Testing test, is essentially a no-op. During migration to Swift Testing, this could lead to false positives if the helpers function are not converted to use Swift Testing APIs.During the transition, update all helper functions to detect whether the caller is executing in the XCTest or Swift Testing context, and call the appropriate API given the library.