[BuildPlan] Fix traverseModules to account for tests with direct ma…
#8940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cro dependencies This change aligns `traverseModules` with `computeDestinations` in regard to test targets that have direct macro dependencies: if at least one test target directly depends on a macro, all of the tests are built for the "host". Resolves: swiftlang/sourcekit-lsp#2205
xedin
requested review from
jakepetroules,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
bkhouri,
cmcgee1024 and
daveyc123
as code owners
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
|
Thanks @xedin. I can confirm this fixes the issue 🙇 |
bnbarham
approved these changes
Jul 16, 2025
dschaefer2
approved these changes
Jul 16, 2025
xedin
added a commit
that referenced
this pull request
Jul 17, 2025
…ct ma… (#8943) …cro dependencies - Explanation: This change aligns `traverseModules` with `computeDestinations` in regard to test targets that have direct macro dependencies: if at least one test target directly depends on a macro, all of the tests are built for the "host". - Resolves: swiftlang/sourcekit-lsp#2205 - Resolves: rdar://155814321 - Main Branch PR: #8940 - Risk: Low. This functionality is only used by sourcekit-lsp at the moment and shouldn't have any impact on swiftpm operation. - Reviewed By: - - Testing: Added new test-cases to the suite. (cherry picked from commit a3e78e2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…cro dependencies
Motivation:
Currently there is a difference in behavior between
BuildPlan.computeDestinationsandBuildPlan.traverseModuleswhere the latter always returns test targets as built for the "target". This is incorrect if i.e. targets have direct macro
dependencies.
Modifications:
This change aligns
traverseModuleswithcomputeDestinationsin regard to test targets that are built for the host.And let's test targets be discovered through an aggregate produce that also informs their destination.
Result:
The fix helps sourcekit-lsp to correctly identify test targets.
Resolves: swiftlang/sourcekit-lsp#2205