Skip to content

Temporarily skip a Swift Build test to allow staging in changes to the test product type. #8758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025
Merged

Temporarily skip a Swift Build test to allow staging in changes to the test product type. #8758

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Tests/CommandsTests/PackageCommandTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4081,14 +4081,13 @@ class PackageCommandSwiftBuildTests: PackageCommandTestCase {
throw XCTSkip("SWBINTTODO: Build plan is not currently supported")
}

#if !os(macOS)
Copy link
Contributor Author

@owenv owenv Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing locally this test works for me on macOS, so I don't think this is needed anymore

override func testCommandPluginTestingCallbacks() async throws {
throw XCTSkip("SWBINTTODO: Requires PIF generation to adopt new test runner product type")
try XCTSkipOnWindows(because: "TSCBasic/Path.swift:969: Assertion failed, https://github.com/swiftlang/swift-package-manager/issues/8602")
try XCTSkipIfWorkingDirectoryUnsupported()

try await super.testCommandPluginTestingCallbacks()
}
#endif

override func testCommandPluginTargetBuilds() async throws {
try XCTSkipOnWindows(because: "TSCBasic/Path.swift:969: Assertion failed, https://github.com/swiftlang/swift-package-manager/issues/8602")
Expand Down