Skip to content

Allow staging in new BuildSettings.Declaration cases without introducing failures #8724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025
Merged

Allow staging in new BuildSettings.Declaration cases without introducing failures #8724

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions Sources/SwiftBuildSupport/PackagePIFBuilder+Helpers.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -902,6 +902,9 @@ extension ProjectModel.BuildSettings {

case .ARCHS, .IPHONEOS_DEPLOYMENT_TARGET, .SPECIALIZATION_SDK_OPTIONS:
fatalError("Unexpected BuildSettings.Declaration: \(setting)")
// Allow staging in new cases
default:
fatalError("Unhandled enum case in BuildSettings.Declaration. Will generate a warning until we have SE-0487")
}
} else {
switch setting {
Expand All @@ -921,6 +924,9 @@ extension ProjectModel.BuildSettings {

case .ARCHS, .IPHONEOS_DEPLOYMENT_TARGET, .SPECIALIZATION_SDK_OPTIONS:
fatalError("Unexpected BuildSettings.Declaration: \(setting)")
// Allow staging in new cases
default:
fatalError("Unhandled enum case in BuildSettings.Declaration. Will generate a warning until we have SE-0487")
}
}
}
Expand Down Expand Up @@ -949,6 +955,9 @@ extension ProjectModel.BuildSettings.MultipleValueSetting {
self = .SWIFT_ACTIVE_COMPILATION_CONDITIONS
case .ARCHS, .IPHONEOS_DEPLOYMENT_TARGET, .SWIFT_VERSION:
return nil
// Allow staging in new cases
default:
fatalError("Unhandled enum case in BuildSettings.Declaration. Will generate a warning until we have SE-0487")
}
}
}
Expand Down