[Traits] Re-enable no unused dependencies assertion in TraitTests.swift
#8360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this check was disabled since it introduced failures when testing with another toolchain (6.1) - due to the introduction of traits in resolution and additional behaviour from the experimental prune dependencies flag, this check should now pass in the TraitTests.
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test linux self hosted |
Additional testing added to ensure appropriate behaviour from omitting unused dependencies, depending on various trait configurations and unused dependency configurations. Renamed dependenciesGuarded -> dependenciesTraitGuarded in `Manifest` for better clarity on what the method is computing, with an improved description.
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please smoke test Linux |
Contributor
Author
|
@swift-ci please test windows |
Contributor
Author
|
@swift-ci please smoke test linux |
bripeticca
requested review from
MaxDesiatov,
bkhouri,
bnbarham,
dschaefer2,
jakepetroules,
owenv,
plemarquand,
shawnhyam and
xedin
as code owners
MaxDesiatov
reviewed
Mar 13, 2025
MaxDesiatov
reviewed
Mar 13, 2025
MaxDesiatov
reviewed
Mar 13, 2025
MaxDesiatov
approved these changes
Mar 13, 2025
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8131
Previously this check was disabled since it introduced failures when testing with the 6.1 toolchain - due to the introduction of traits in resolution (#8205) and additional behaviour from the experimental prune dependencies flag, this check should now pass as expected.
Modifications:
Re-enabled the
XCTAssertFalse(stderr.contains("warning:"))check in theTraitTestswhere necessary and propagated thepruneDependenciesflag to theManifestLoaderinit in areas it was previously missing to assure no warnings would be generated upon omitting them. Also re-added the enabled traits parameter done during a computation for required dependencies when creating the package builders inModulesGraph+Loading.swift.Result:
This check shouldn't fail anymore.