Skip to content

Fix call to SWBBuildService.createSession #8357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix call to SWBBuildService.createSession #8357

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion Sources/SwiftBuildSupport/SwiftBuildSystem.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,14 @@ func withSession(
_ diagnostics: [SwiftBuild.SwiftBuildMessage.DiagnosticInfo]
) async throws -> Void
) async throws {
switch await service.createSession(name: name, resourceSearchPaths: packageManagerResourcesDirectory.map { [$0.pathString] } ?? [], cachePath: nil, inferiorProductsPath: nil, environment: nil) {
switch await service.createSession(
name: name,
developerPath: nil,
Copy link
Contributor

@owenv owenv Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

developerPath defaults to nil, so it shouldn't be needed here. Were you seeing the build fail in some configuration?

Copy link
Contributor Author

@plemarquand plemarquand Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think my dependencies got in to a bad state, I switched to a known good toolchain, cleaned and rebuilt and its not an issue.

Copy link
Member

@dschaefer2 dschaefer2 Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. Need to remember to swift package update regularly to get the latest swift build.

resourceSearchPaths: packageManagerResourcesDirectory.map { [$0.pathString] } ?? [],
cachePath: nil,
inferiorProductsPath: nil,
environment: nil
) {
case (.success(let session), let diagnostics):
do {
try await body(session, diagnostics)
Expand Down