Add an expectation of a warning diagnostic to tests that hide libSwiftScan.
#7995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemcm
requested review from
MaxDesiatov,
bnbarham,
bripeticca,
dschaefer2,
francescomikulis,
jakepetroules,
owenv,
plemarquand,
shawnhyam and
xedin
as code owners
|
@swift-ci test |
artemcm
force-pushed
the
ExpectNoLibSwiftcanWarnOnHide
branch
2 times, most recently
from
98d6cba to
bb9351d
Compare
owenv
approved these changes
Sep 23, 2024
|
From Smoke test and cross-repo test: I don't think these are related. |
|
swiftlang/swift-syntax#2858 resolved the above failures. Re-testing. |
|
@swift-ci test |
1 similar comment
artemcm
force-pushed
the
ExpectNoLibSwiftcanWarnOnHide
branch
from
bb9351d to
7ad725f
Compare
artemcm
force-pushed
the
ExpectNoLibSwiftcanWarnOnHide
branch
from
7ad725f to
6aa6d8f
Compare
…tScan. Such tests cause the driver to take a code-path that results in a warning: 'warning: Unable to locate libSwiftScan. Fallback to `swift-frontend` dependency scanner invocation.' This needs to be taken into account.
artemcm
force-pushed
the
ExpectNoLibSwiftcanWarnOnHide
branch
from
6aa6d8f to
9e2afee
Compare
|
swiftlang/swift-driver#1703 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Such tests cause the driver to take a code-path that results in a warning:
warning: Unable to locate libSwiftScan. Fallback toswift-frontenddependency scanner invocation.This needs to be taken into account.