[PackageDescription] Deprecated swiftLanguageVersion should result …
#7825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in `swiftLanguageMode` setting Otherwise manifest loading is going to fail because `swiftLanguageVersion` has been removed. Resolves: swiftlang#7823
xedin
requested review from
bnbarham,
MaxDesiatov,
jakepetroules and
francescomikulis
as code owners
|
@swift-ci please test |
MaxDesiatov
approved these changes
Jul 25, 2024
xedin
added a commit
that referenced
this pull request
Jul 25, 2024
…sult … (#7826) …in `swiftLanguageMode` setting - Explanation: Otherwise manifest loading is going to fail because `swiftLanguageVersion` has been removed. - Main Branch PR: #7825 - Resolves: #7823 - Resolves: rdar://132484168 - Risk: Very Low (fixes a bug). - Reviewed By: @MaxDesiatov - Testing: New tests were added. (cherry picked from commit d1405f2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…in
swiftLanguageModesettingOtherwise manifest loading is going to fail because
swiftLanguageVersionhas been removed.Resolves: #7823
Resolves: rdar://132484168