Suppress Swift Testing invocation when XCTMain.swift or LinuxMain.swift is present. #7787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ft is present. If a test entry point source file is present in a package, that means our own entry point code won't run, so we can't reliably run Swift Testing. This is a legacy configuration but is still used by a number of packages in the Swift ecosystem. Further deprecation of this feature is something to consider after Swift 6.0.
grynspan
requested review from
MaxDesiatov,
bnbarham,
francescomikulis,
jakepetroules and
xedin
as code owners
|
@swift-ci please test |
|
@swift-ci please test |
|
@swift-ci please test Windows |
|
@swift-ci please test |
xedin
approved these changes
Jul 17, 2024
|
@swift-ci please test |
briancroom
approved these changes
Jul 17, 2024
grynspan
added a commit
that referenced
this pull request
Jul 17, 2024
…Testing enabled by default.) (#7766) This PR refactors the previously-experimental Swift Testing support logic so that only a single build product is produced when using both XCTest and Swift Testing, and detection of Swift Testing usage is no longer needed at compile time. On macOS, Xcode 16 is responsible for hosting Swift Testing content, so additional changes may be needed in Xcode to support this refactoring. Such changes are beyond the purview of the Swift open source project. This PR includes changes from the previous PRs numbered #7766, #7783, and #7787. Resolves rdar://120864035. --------- Co-authored-by: Pavel Yaskevich <[email protected]>
grynspan
added a commit
that referenced
this pull request
Jul 17, 2024
…Testing enabled by default.) This PR refactors the previously-experimental Swift Testing support logic so that only a single build product is produced when using both XCTest and Swift Testing, and detection of Swift Testing usage is no longer needed at compile time. On macOS, Xcode 16 is responsible for hosting Swift Testing content, so additional changes may be needed in Xcode to support this refactoring. Such changes are beyond the purview of the Swift open source project. This PR includes changes from the previous PRs numbered #7766, #7783, and #7787. Resolves rdar://120864035. --------- Co-authored-by: Pavel Yaskevich <[email protected]>
grynspan
added a commit
that referenced
this pull request
Jul 17, 2024
…Testing enabled by default.) This PR refactors the previously-experimental Swift Testing support logic so that only a single build product is produced when using both XCTest and Swift Testing, and detection of Swift Testing usage is no longer needed at compile time. On macOS, Xcode 16 is responsible for hosting Swift Testing content, so additional changes may be needed in Xcode to support this refactoring. Such changes are beyond the purview of the Swift open source project. This PR includes changes from the previous PRs numbered #7766, #7783, and #7787. Resolves rdar://120864035. --------- Co-authored-by: Pavel Yaskevich <[email protected]>
grynspan
added a commit
that referenced
this pull request
Jul 18, 2024
…Testing enabled by default.) (#7789) This PR refactors the previously-experimental Swift Testing support logic so that only a single build product is produced when using both XCTest and Swift Testing, and detection of Swift Testing usage is no longer needed at compile time. On macOS, Xcode 16 is responsible for hosting Swift Testing content, so additional changes may be needed in Xcode to support this refactoring. Such changes are beyond the purview of the Swift open source project. This PR includes changes from the previous PRs numbered #7766, #7783, #7784, and #7787. Resolves rdar://120864035. Co-authored-by: Pavel Yaskevich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a test entry point source file is present in a package, that means our own entry point code won't run, so we can't reliably run Swift Testing. This is a legacy configuration but is still used by a number of packages in the Swift ecosystem.
Further deprecation of this feature is something to consider after Swift 6.0.