[5.10] Fix test runner build on WASI #7351
Merged
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test runner build was failing on WASI after the introduction of the experimental summary output. This PR fixes several minor issues to pass `--build-tests` build on WASI: * Missing `WASILibc` import * The use of `flock` which is not available on WASI. * Signature incompatibility of `XCTMain` on WASI. `swift build --build-tests --triple wasm32-unknown-wasi` will pass when compiler supports the target.
kateinoigakukun
requested review from
MaxDesiatov,
neonichu and
tomerd
as code owners
kateinoigakukun
added
swift 5.10
12 tasks
|
Can we include this fix in the next point release? |
|
@swift-ci test |
MaxDesiatov
requested review from
airspeedswift,
bnbarham,
briancroom and
grynspan
grynspan
approved these changes
Mar 18, 2024
briancroom
approved these changes
Mar 18, 2024
airspeedswift
approved these changes
Apr 3, 2024
MaxDesiatov
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍒 #7341
swift build --build-testsfails on WASI after the experimental summary output, which is introduced in 5.10. This affects not only experimental-summary mode but also the default output mode.