[5.9] Add and fix missing Triple tests, fix soundness checks #6843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDesiatov
added
bug
swift 5.9
MaxDesiatov
requested review from
abertelrud,
neonichu and
tomerd
as code owners
MaxDesiatov
changed the title
|
@swift-ci smoke test |
(cherry picked from commit cfb7836)
MaxDesiatov
force-pushed
the
maxd/5.9-fix-triple-soundness
branch
from
047a408 to
0ab5eab
Compare
|
@swift-ci smoke test |
|
@swift-ci test windows |
(cherry picked from commit 8de70d3)
|
@swift-ci smoke test |
|
@swift-ci test windows |
|
@swift-ci smoke test linux |
|
@swift-ci test windows |
1 similar comment
|
@swift-ci test windows |
tomerd
approved these changes
Aug 23, 2023
neonichu
approved these changes
Aug 23, 2023
|
@swift-ci smoke test linux |
MaxDesiatov
added a commit
that referenced
this pull request
Sep 20, 2023
Cherry-pick of #6843 Vendored Swift Driver triple was not checked against a few tests that weren't brought over from TSC after `TSC.Triple` type was deprecated. We should fix those tests, especially as they verified that per-component equality for triples worked instead of the current string-based equality check. (cherry picked from commit 8de70d3) ``` # Conflicts: # Tests/BasicsTests/TripleTests.swift ``` Related to rdar://113967401 Maybe related to rdar://115731621
MaxDesiatov
added a commit
that referenced
this pull request
Sep 28, 2023
Cherry-pick of #6843 Vendored Swift Driver triple was not checked against a few tests that weren't brought over from TSC after `TSC.Triple` type was deprecated. We should fix those tests, especially as they verified that per-component equality for triples worked instead of the current string-based equality check. (cherry picked from commit 8de70d3) ``` # Conflicts: # Tests/BasicsTests/TripleTests.swift ``` Related to rdar://113967401 Maybe related to rdar://115731621
MaxDesiatov
added a commit
that referenced
this pull request
Sep 28, 2023
Cherry-pick of #6843 Vendored Swift Driver triple was not checked against a few tests that weren't brought over from TSC after `TSC.Triple` type was deprecated. We should fix those tests, especially as they verified that per-component equality for triples worked instead of the current string-based equality check. (cherry picked from commit 8de70d3) ``` # Conflicts: # Tests/BasicsTests/TripleTests.swift ``` Related to rdar://113967401 Maybe related to rdar://115731621
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #6842.
Vendored Swift Driver triple was not checked against a few tests that weren't brought over from TSC after
TSC.Tripletype was deprecated. We should fix those tests, especially as they verified that per-component equality for triples worked instead of the current string-based equality check.Also fixed some of the
Utilities/soundness.shscript failures.(cherry picked from commit cfb7836)