[5.9] Fix backward compatibility in host triple checks #6820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDesiatov
added
bug
swift 5.9
MaxDesiatov
requested review from
abertelrud,
neonichu and
tomerd
as code owners
|
@swift-ci smoke test |
MaxDesiatov
changed the title
It's useful to be able to set host triple in Swift SDKs to `arm64-apple-macosx13.0` to allow cross-compiling from an older version of macOS. This triple is not recognized as directly matching `arm64-apple-macosx14.0` on a newer version of macOS. We should support backward compatibility with Swift SDKs that were built for older version of macOS. (cherry picked from commit 82b1e83) # Conflicts: # Sources/PackageModel/SwiftSDKBundle.swift # Tests/PackageModelTests/SwiftSDKBundleTests.swift
MaxDesiatov
force-pushed
the
maxd/5.9-host-triple-check
branch
from
168769b to
79be31a
Compare
|
@swift-ci smoke test |
|
@swift-ci test windows |
1 similar comment
|
@swift-ci test windows |
tomerd
approved these changes
Aug 24, 2023
|
@swift-ci test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #6819.
When setting host triple in Swift SDKs to
arm64-apple-macosx13.0to allow cross-compiling from an older version of macOS, this triple is not recognized as directly matchingarm64-apple-macosx14.0on a newer version of macOS.We should support backward compatibility with Swift SDKs that were built for older version of macOS.
(cherry picked from commit 82b1e83)
Resolves rdar://113967401.